Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/pcolarco/carma gocart2g coupling #271

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

pcolarco
Copy link
Contributor

@pcolarco pcolarco commented Dec 22, 2023

Fixed some CARMA and GEOS_ChemGridComp code to couple GOCART sulfate production tendency to CARMA sulfur mechanism. Also fixed the CARMA radiation callback name to work with updated GEOS radiation. Change is zero-diff if not running CARMA. If running CARMA prevents a crash if CARMA is radiation AERO_PROVIDER.

mmanyin and others added 6 commits November 9, 2022 11:19
Fix for GMI GCRs; refactored StratChem resource files
GAAS now works with ExtData; maintenance and bug-fixes for TR, GMI and StratChem
Split off GMI, StratChem and TR (dev to main)
Updates to CARMA, and QFED paths
Add support for GMI/GOCART2G coupling; new wrapper for MAPL SZA
…eld/tendency checking in CARMA; correct run_aerosol_optics method to couple CARMA radiation to GEOSradiation
@pcolarco pcolarco requested review from a team as code owners December 22, 2023 20:12
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@pcolarco pcolarco added the bugfix This fixes a bug label Dec 22, 2023
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

1 similar comment
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 22, 2023
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @pcolarco says, no change unless CARMA is running. Also note - for CARMA to work, you must use the fix found in GOCART PR 260 .

@mmanyin mmanyin merged commit 6436e3a into develop Dec 22, 2023
10 of 11 checks passed
@mmanyin mmanyin deleted the features/pcolarco/CARMA_GOCART2G_coupling branch December 22, 2023 22:20
@pcolarco
Copy link
Contributor Author

pcolarco commented Dec 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants