Disable Catchment-CN4.5 land model option (LSM_CHOICE=3) for GCM simulations #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmao-jkolassa
added
the
0 diff trivial
|
Note to @sshakoor1: this will probably need to be done in #544 as well. Though I suppose once this gets in, git would merge the change... |
gmao-rreichle
changed the title
gmao-rreichle
approved these changes
Feb 15, 2024
|
Yes, I ran gcm_setup with these modifications trying both LSM_CHOICE=2 and LSM_CHOICE=3 (which is no longer a valid choice). The only options for LSM_CHOICE that are displayed in the interactive script are 1 (Catchment) and 2 (Catchment-CN4.0). And trying to set LSM_CHOICE=3 (Catchment-CN4.5), triggers the error message (which is how I noticed the typo in the error message) |
Thanks, @gmao-jkolassa. I'm marking this as "ready for review", @sdrabenh. Please let us know if you have any questions. |
sdrabenh
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the option for using the Catchment-CN4.5 land model (LSM_CHOICE=3) in GCM simulations. The PR also fixes a minor typo that was present in the error message displayed for invalid values of LSM_CHOICE.
This PR is zero-diff.
Related PRs:
GEOS-ESM/GEOSldas#707
GEOS-ESM/GEOSgcm_GridComp#900
cc: @gmao-rreichle , @biljanaorescanin