Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified RUN1 to load balance #647

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

aoloso
Copy link
Contributor

@aoloso aoloso commented Sep 22, 2022

Subroutine RUN1 of GEOS_CICE4ColumnPhysGridComp is modified to for load balancing similar to what was previously done for subroutine CICECORE in subroutine RUN2.

@aoloso aoloso added the 0 diff structural Structural changes to repository that are zero-diff label Sep 22, 2022
@aoloso aoloso requested review from a team as code owners September 22, 2022 14:26
@sanAkel
Copy link
Contributor

sanAkel commented Sep 22, 2022

FWIW, these changes provide a slight speed up:

All runs are for 1 month with cas.

Ocean Model | NCPUS | mean wallclock time before update (number of simulations) | mean wallclock time after update (number of simulations) |
MOM5 | 1440 | 145 min (1) | 136 min (2) |
MOM6 | 1440 | 193 min (3) | 196 min (1) | **there was a variability of > 20 min in my runs before update.

Copy link
Contributor

@sanAkel sanAkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying up other components besides sea ice (CICE4). (Reviewing on behalf of the @GEOS-ESM/ocean-team)

Copy link
Contributor

@zhaobin74 zhaobin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoloso, thanks for this PR. But I see you also brought in changes to other components not related to CICE4 load balance. I am not able to review all of them.

Copy link
Contributor

@zhaobin74 zhaobin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sea ice components are fine. Approve.

@sdrabenh sdrabenh merged commit 5c38912 into develop Sep 22, 2022
@sdrabenh sdrabenh deleted the feature/aoloso/CICE4_RUN1_load_balance branch September 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants