Feature/adarmenov/ignio #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync develop into main
Sync develop into main
Wind at 2m, temperature and humidity at 10m, are not used, hence they can be removed from the import spec.
This refactoring reproduces the initial implementation. There is no notable speed up. Slightly smaller code, however some of the changes may have resulted in more difficult to read code.
Define the CFFWI functions as elemental. Tidy up comments.
…al use Monthly day length adjustment factors for Drought Code (Lf) can be applied for northern and southern hemispheres. Based on Appendix 3 in Lawson and Armitage (2008). Add utility test for the monthly day length adjustment factors for Drought Code (Lf).
Hourly FFMC is based on:
- A method of computing fine fuel moisture content
throughout the diurnal cycle, C.E. Van Wagner, 1977.
- A comparison of hourly fine fuel moisture code calculations
within Canada, K. Anderson, 2009.
For now the FWI indexes are calculated daily.
The FF scale in the reference documents is: m = 147.2*(101 - F) / (59.5 + F) F = 59.5*(250 - m)/(147.2 + m) A. Cantin et al., however recommend a more precise version, especially for hourly or finer timesteps: m = 147.27723*(101 - F) / (59.5 + F) F = 59.5*(250 - m)/(147.27723 + m)
The wind term used in ISI is modified to follow the FBP system - see Section 7.2.2, Eq. 53 and Eq. 53a in 'Development and Structure of the Canadian Forest Fire Behavior Prediction System, Technical ReportST-X-3, Forestry Canada, 1992.'
Grass fuel moisture code (GFMC) is based on:
Wotton, B.M., A grass moisture model for the Canadian
Forest Fire Danger Rating System, 2009.
The CFFWI implementation in GEOS now provides both daily and hourly fuel moisture codes and fire behavior indexes.
Hourly and daily FFMC, DMC, DC, ISI, FWI and DSR are now included in the SURFACE export spec.
For now GFMC is computed with fixed nominal fine fuel load.
The nominal fine fuel load was updated to 0.35 kg m-2 based on the recommended value in Section 3.1.2 in 'Updates and Revisions to the 1992 Canadian Forest Fire Behavior Prediction System', GLC-X-10, 2009.
Default to LST local noon method until MAPL_SunGetLocalSolarHourAngle() makes it into the main MAPL branch.
adarmenov
added
enhancement
sanAkel
suggested changes
Feb 1, 2023
...m_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOS_LandGridComp.F90
Outdated
Show resolved
Hide resolved
|
Based on a brief inspection of the changes this looks ok to me from the land perspective. |
zhaobin74
approved these changes
Feb 1, 2023
@gmao-rreichle Addressed with 04821aa |
tclune
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Please note that CMake provides a mechanism to register tests, and thereby make it easier for us to incorporate them into CI testing. It would also avoid hardcoding the compiler (gfortran in this case)
If at all interested please contact @mathomp4 or myself.
sanAkel
approved these changes
Feb 1, 2023
Yes, I'm interested and will reach out to @mathomp4. Thanks! |
biljanaorescanin
approved these changes
Feb 2, 2023
sdrabenh
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGNI is a new component that integrates fire weather observations into fuel moisture codes and fire behavior indexes based on the CFFWI system.