Unnecessary yaFyaml dependency in GOCART build system

[rmontuoro]

yaFyaml is not needed to build GOCART. However, the following dependency is included in the build system:

GOCART/CMakeLists.txt

Line 64 in e59ddd4

find_package (YAFYAML REQUIRED)

[mathomp4]

Ah. Nuts. Yeah. We probably need a "build like UFS" build test here as well.

@rmontuoro In MAPL we handle this via USE_EXTDATA2G. I'm guessing you are building MAPL with -DUSE_EXTDATA2G=NO?

[rmontuoro]

@mathomp4 - yes, we build MAPL with -DUSE_EXTDATA2G=NO in the UFS.

The yaFyaml dependency is required by MAPL though, not GOCART.

[mathomp4]

True. Indeed, there seem to be a lot of unneeded find_package in GOCART:

GOCART/CMakeLists.txt

Lines 61 to 64 in 4c94179

	find_package (GFTL REQUIRED)
	find_package (GFTL_SHARED REQUIRED)
	find_package (PFLOGGER QUIET)
	find_package (YAFYAML REQUIRED)

Those are needed by MAPL, not GOCART. @rmontuoro if I make up a hotfix patch, can you test it?

[rmontuoro]

@mathomp4 - sure. Thanks!

[mathomp4]

@rmontuoro Can you actually tell me exactly how you are building MAPL now? That is what CMake options? I should capture that.

[rmontuoro]

Here they are:
https://github.com/NOAA-EMC/hpc-stack/blob/74a20edac33e66b59aa82fed47c7b8189c14363c/libs/build_mapl.sh#L69-L78

[mathomp4]

@rmontuoro Okay can you try the hotfix/mathomp4/184-ufs-cmake-fix? (see #185)

[mathomp4]

@rmontuoro Actually, another question: what version of GOCART are you using? My draft PR is based on our main which is 2.1.0, but if you still use an older version, I'll need to hotfix that too.

[rmontuoro]

@mathomp4 - Thank you.
We are currently using rev. a342b1b in the ufs-weather-model

[mathomp4]

@mathomp4 - Thank you. We are currently using rev. a342b1b in the ufs-weather-model

Ah. Good then we can (for now) just hotfix 2.1.0 since you are (essentially) on that. I'm doing testing now and will coordinate with @amdasilva about getting a v2.1.1 out for you.

[rmontuoro]

@mathomp4 - hotfix/mathomp4/184-ufs-cmake-fix built successfully in the UFS after minor modifications listed in #185 (comment)