Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update State Specs for *-expansion in Long Names #202

Closed
mathomp4 opened this issue Dec 15, 2022 · 2 comments · Fixed by #205
Closed

Update State Specs for *-expansion in Long Names #202

mathomp4 opened this issue Dec 15, 2022 · 2 comments · Fixed by #205
Assignees

Comments

@mathomp4
Copy link
Member

mathomp4 commented Dec 15, 2022

@darianboggs recently added the ability in MAPL to expand * in long name with the ACG:

GEOS-ESM/MAPL#1881

This feature will be in the next version of MAPL (2.34.0) which will be released "soon". As such, this is an issue reminder to update the state specs in files where star-expansion is done. At the moment I think it's only in CA:

NAME | UNITS | DIMS | VLOC | UNGRIDDED | LONG NAME
#----------------------------------------------------------------------------------------
*MASS | kg kg-1 | xyz | C | | Carbonaceous Aerosol Mass Mixing Ratio
*CONC | kg m-3 | xyz | C | | Carbonaceous Aerosol Mass Concentration

but others might use it in branches in development? The above lines should become:

 NAME         | UNITS        | DIMS  | VLOC  | UNGRIDDED                      | LONG NAME
#----------------------------------------------------------------------------------------
 *MASS        | kg kg-1      | xyz   | C     |                                | * Carbonaceous Aerosol Mass Mixing Ratio
 *CONC        | kg m-3       | xyz   | C     |                                | * Carbonaceous Aerosol Mass Concentration

as an example. Note you want to make sure you have the space so this:

* Carbonaceous ...

not:

*Carbonaceous ...

as the Python will do:

CA.bcCarbonaceous ...

for the latter.

@mathomp4
Copy link
Member Author

mathomp4 commented Jan 5, 2023

Note also as of GEOS-ESM/MAPL#1899, the %d is also expanded. So if you update specs with the * you will get:

        float BCDP001(time, lat, lon) ;
                BCDP001:long_name = "CA.bc Carbonaceous Aerosol Dry Deposition (Bin 001)" ;

MAPL 2.34 should be released today.

@mathomp4
Copy link
Member Author

mathomp4 commented Jan 9, 2023

Wait. I just realized this isn't quite right. I need to work with @darianboggs.

@mathomp4 mathomp4 linked a pull request Jan 9, 2023 that will close this issue
amdasilva added a commit that referenced this issue Jan 24, 2023
…tespecs

Fixes #202. Add * to Long Name for CA Gridded Component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants