Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI CI to use Orb. Update components #123

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 14, 2022

This PR updates the CI here to use the more modern circleci-tools orb for reusable configs. This also has the benefits of builds with both gfortran and intel!

It also updates the components.yaml to better match GOCART2G GEOSgcm.

I've also added a .editorconfig file to match the styles used in MAPL

  • 2 space indents for CMake and YAML
  • 4 space indents for Python (per PEP 8)

Note that for most legacy editors (emacs, vim, etc.), EditorConfig needs a plugin to be enabled, so for most people this is a no-op, but if you have it on, it helps enforce a style for a few files.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 14, 2022
@mathomp4 mathomp4 self-assigned this Mar 14, 2022
@mathomp4 mathomp4 marked this pull request as ready for review March 16, 2022 16:44
@mathomp4 mathomp4 requested review from a team as code owners March 16, 2022 16:44
tclune
tclune previously approved these changes Mar 16, 2022
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes ok.

adarmenov
adarmenov previously approved these changes Mar 16, 2022
Copy link

@adarmenov adarmenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in HEMCO are harmless. Approved.

@mathomp4 mathomp4 requested a review from tclune March 17, 2022 20:52
@mathomp4 mathomp4 dismissed stale reviews from adarmenov and tclune via b5406d6 March 17, 2022 20:52
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine...

@amdasilva amdasilva merged commit 9737da6 into develop Mar 17, 2022
@amdasilva amdasilva deleted the feature/mathomp4/update-circleci-gocart branch March 17, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants