Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS and update components to match GEOSgcm v10.22.1 #124

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 18, 2022

This PR updates the CODEOWNERS file so that PR approvals here are less onerous. Only the CI and weird CCPP/UFS directories will need approval from non-aerosol team members.

NOTE: I think this will not truly take effect until this change is in main due to the way GitHub works. (Only the CODEOWNERS on main matters to GitHub. Annoying, but it's how they do things.)


ETA: I've also updated components.yaml to match that of GEOSgcm v10.22.1. The main thing is to get MAPL 2.19.0 which is needed for the new AGC code that is in develop.

@mathomp4 mathomp4 added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Mar 18, 2022
@mathomp4 mathomp4 self-assigned this Mar 18, 2022
@mathomp4 mathomp4 requested review from a team as code owners March 18, 2022 13:02
adarmenov
adarmenov previously approved these changes Mar 18, 2022
tclune
tclune previously approved these changes Mar 18, 2022
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @amdasilva to any directory that does not include aerosol-team.

@mathomp4 mathomp4 dismissed stale reviews from tclune and adarmenov via 49adb04 March 18, 2022 16:47
@mathomp4
Copy link
Member Author

Please add @amdasilva to any directory that does not include aerosol-team.

Done.

adarmenov
adarmenov previously approved these changes Mar 18, 2022
@mathomp4
Copy link
Member Author

Apologies to @adarmenov but he might need a re-approve. I'm going to try and fix the CI. I think I know the issue.

Copy link

@adarmenov adarmenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathomp4 - there are also changes to fixture tags/versions, i.e. the PR is not only update CODEOWNERS(?).

@mathomp4 mathomp4 changed the title Update CODEOWNERS Update CODEOWNERS and update components to match GEOSgcm v10.22.1 Mar 18, 2022
@mathomp4
Copy link
Member Author

@mathomp4 - there are also changes to fixture tags/versions, i.e. the PR is not only update CODEOWNERS(?).

Thanks. I updated the title to the PR to reflect that.

adarmenov
adarmenov previously approved these changes Mar 18, 2022
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mathomp4 mathomp4 merged commit 1824910 into develop Apr 21, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/update-codeowners-gocart branch April 21, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants