-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS and update components to match GEOSgcm v10.22.1 #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @amdasilva to any directory that does not include aerosol-team.
Done. |
Apologies to @adarmenov but he might need a re-approve. I'm going to try and fix the CI. I think I know the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathomp4 - there are also changes to fixture tags/versions, i.e. the PR is not only update CODEOWNERS(?).
Thanks. I updated the title to the PR to reflect that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This PR updates the
CODEOWNERS
file so that PR approvals here are less onerous. Only the CI and weird CCPP/UFS directories will need approval from non-aerosol team members.NOTE: I think this will not truly take effect until this change is in
main
due to the way GitHub works. (Only theCODEOWNERS
onmain
matters to GitHub. Annoying, but it's how they do things.)ETA: I've also updated
components.yaml
to match that of GEOSgcm v10.22.1. The main thing is to get MAPL 2.19.0 which is needed for the new AGC code that is indevelop
.