Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in getAerosolSum #139

Merged
merged 5 commits into from
May 26, 2022
Merged

fix bug in getAerosolSum #139

merged 5 commits into from
May 26, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@amdasilva , This is for the issue #136. I am not sure if it a good fix. Please verify it.

@weiyuan-jiang weiyuan-jiang added the bug Something isn't working label Apr 14, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner April 14, 2022 13:24
adarmenov
adarmenov previously approved these changes Apr 14, 2022
@mathomp4
Copy link
Member

@weiyuan-jiang Do you know if this is a zero-diff change?

@weiyuan-jiang
Copy link
Contributor Author

@mathomp4 It is supposed not. But if this subroutine is not used in the benchmark, then it is zero-diff

@mathomp4 mathomp4 added Non 0-diff The changes in this pull request are non-zero-diff 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Apr 21, 2022
adarmenov
adarmenov previously approved these changes Apr 22, 2022
amdasilva
amdasilva previously approved these changes May 26, 2022
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@amdasilva amdasilva dismissed stale reviews from adarmenov and themself via 2fe4a45 May 26, 2022 14:39
Copy link
Contributor

@vbuchard vbuchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@amdasilva amdasilva closed this May 26, 2022
@amdasilva amdasilva reopened this May 26, 2022
@amdasilva amdasilva merged commit bbb6a55 into develop May 26, 2022
@amdasilva amdasilva deleted the bugfix/wjiang/getAerosolSum branch May 26, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug Something isn't working Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants