Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #156 #158

Merged
merged 2 commits into from
May 27, 2022
Merged

Fixes #156 #158

merged 2 commits into from
May 27, 2022

Conversation

bena-nasa
Copy link
Contributor

This fixes issue #156
There continues that should have been cycles in the GOCART2G process library. This was causing the loop not to break when it should have and an out of bounds error to occur.

@bena-nasa bena-nasa requested a review from a team as a code owner May 27, 2022 13:25
@bena-nasa bena-nasa requested a review from tclune May 27, 2022 13:25
@bena-nasa bena-nasa added the bug Something isn't working label May 27, 2022
@bena-nasa bena-nasa requested a review from amdasilva May 27, 2022 13:27
@bena-nasa bena-nasa added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 27, 2022
@bena-nasa bena-nasa requested a review from vbuchard May 27, 2022 15:36
Copy link
Contributor

@vbuchard vbuchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vbuchard vbuchard merged commit 7c85d6e into develop May 27, 2022
@vbuchard vbuchard deleted the feature/bmauer/fixes-#156 branch May 27, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants