Feature/aoloso/hybrid openmp issue#181 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce condition when using OpenMP
…hat are not part of the original list of internal fields to MAPL_RestartSkip to esnure zero-diff with stock
aoloso
added
the
0 diff structural
…hreads and current thread
|
I am going to hold on to this PR until Virginie checks in her latest diagnostic mods and ask you to remerge to develop. I want to make sure Virginie does not miss any of these OMP mods. Also, we will need to be educated to maintain this capability. It would be very easy for someone to add code and mess this up. |
|
@amdasilva @vbuchard NOAA has been very patient, but is continuing to ask when this capability will be available in GOCART ... @aoloso Could you update the branch and see if anything needs fixing for a new merge? |
amdasilva
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were made so GOCART2G and its children can be run with component level
OpenMP threading. The key change is to create the data structure ThreadWorkspace
to hold variables that should be private to each thread to avoid race conditions.
Additionally spatially distributed arrays that were not in any of the ESMF states
were added to the ESMF internal state so they could be properly handled when
the 'mini' ESMF sates are created. Those arrays are xhno3 for NI2G, h202_init
for SU2G, and deep_lakes_mask for SS2G. All of these arrays have MAPL_RestartSkip
option so they are not written to restart.