Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GOCART2G can run without the NI component. #221

Merged
merged 3 commits into from
May 4, 2023

Conversation

rmontuoro
Copy link
Contributor

This PR fixes issue #220.

@rmontuoro rmontuoro requested a review from a team as a code owner March 31, 2023 17:43
@tclune
Copy link
Contributor

tclune commented Mar 31, 2023

@amdasilva Ordinarily, I'd recommend that this be a hotfix onto main as we may already be experiencing issues related to this on several fronts. Please let us know.

@tclune
Copy link
Contributor

tclune commented Apr 4, 2023

I discussed the PR with Arlindo. He agrees that this is a suitable fix. (No promises on when it gets merged though. :-)

amdasilva
amdasilva previously approved these changes May 4, 2023
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable solution.

@amdasilva amdasilva added bug Something isn't working 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels May 4, 2023
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants