Fix 3 hourly frequency update in go-cart to allow start/stop regression in less than 3 hour chances #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
added
0 diff
vbuchard
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #146
This fixes a long standing issue that one can not start and stop the model in anything less than 3 hour increments to test start/stop regression because of GOCART
I will not rehash why this occurring other than to say this is unacceptable. If you look in the issue you will see all the details. The one thing I had to do was remove ESFM alarms, the whole problem was that an alarm was made relative to the model start time which just can not be. But the problem is if the ESMF Alarm is created correctly, say at 0z of the day so that no matter when you start you get the same behavior, it does not work right as there are fundamental bugs in ESMF alarms. ESMF is aware of this and will fix it some day, but until then we must avoid using them. In it's place I made a simple function that says is my time some frequency from 0z during the day.
This is zero-diff in my test and allows one to do start/stop regression at less than 3 hour increments which is very, very useful for debugging when you need it and multiple people have wasted time doing regression tests and were not aware of this "bug". Plus this what was coded was fundamentally not right.
Note I made the same function in two routines as I did not see any common place in GOCART2G for helper procedures such as this to go, although if there is, or we should invent one, I can do that.