-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync tag sdr_v2.1.2.6 into develop #232
Sync tag sdr_v2.1.2.6 into develop #232
Conversation
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but see #231 regarding architecture violation (which has been introduced prior to this PR).
@sdrabenh I updated the |
Also just fixed a bad-merge line causing a CI failure. And updated the |
Update: I've added the bugfix I talk about in #234 here as well as I think it is a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, the microphysics callback needs work as it now consulting the GCM rc file to find out about its coupling context, something that is an architecture violation.
@amdasilva this PR captures the changes made to accommodate Krok. Please see the owners of the commits below for questions. There were several merge conflicts, so hopefully my hand-merges are correct. I'm unsure at this point whether this PR is 0-diff or not. I would have to test this to be sure. In the meantime I will mark it as both.