Remove layer definition "ideal_vgi_lulc" #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
force-pushed
the
indicator-layer-combination
branch
from
a53adbe
to
183db8d
Compare
|
Two alternatives come to mind. Both would keep the layer definition and ...
|
|
Hey @matthiasschaub , |
Hagellach37
previously approved these changes
Jan 10, 2022
matthiasschaub
force-pushed
the
indicator-layer-combination
branch
2 times, most recently
from
c84c562
to
11efec0
Compare
the Mapping Saturation indicator. Layer definition "IDEAL-VGI Land Use and Land Cover" has been a valid layer in combination with the Mapping Saturation indicator. But often time the area of the land-use gets smaller over time instead of bigger, which makes it not suitable for the Mapping Saturation. Also the layer definition is not used in any Report.
matthiasschaub
force-pushed
the
indicator-layer-combination
branch
from
11efec0
to
3501600
Compare
matthiasschaub
added a commit
that referenced
this pull request
Mar 2, 2022
description in the case that the indicator could not been calculated (instead of raising an error which will not be handed down to the API).
2 tasks
matthiasschaub
added a commit
that referenced
this pull request
Mar 3, 2022
description in the case that the indicator could not been calculated (instead of raising an error which will not be handed down to the API).
matthiasschaub
added a commit
that referenced
this pull request
Mar 7, 2022
description in the case that the indicator could not been calculated (instead of raising an error which will not be handed down to the API). Update lulc layer definition
matthiasschaub
added a commit
that referenced
this pull request
Mar 9, 2022
description in the case that the indicator could not been calculated (instead of raising an error which will not be handed down to the API). Update lulc layer definition
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Layer definition "IDEAL-VGI Land Use and Land Cover" has been a valid
layer in combination with the Mapping Saturation indicator.
But often time the area of the land-use gets smaller over time instead
of bigger, which makes it not suitable for the Mapping Saturation.
Beside that the Layer has not been used in any Report.
Checklist
main(e.g. throughgit rebase main)- [ ] My code follows the style guide and was checked with pre-commit before committing- [ ] I have commented my code- [ ] I have added sufficient unit and integration tests