-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite report aggregation of indicator to use mean value of indicator result class values #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite report aggregation of indicator to use mean value of indicator result class values
matthiasschaub
added
the
waiting
An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked
label
Jul 7, 2022
rewrite report aggregation of indicator to use mean value of indicator result class values
matthiasschaub
force-pushed
the
report-aggregation
branch
from
August 8, 2022 13:37
2b5ddc3
to
bb2c654
Compare
Gigaszi
added
waiting for review
This pull request urgently needs a code review
and removed
waiting
An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked
labels
Sep 11, 2022
matthiasschaub
commented
Sep 20, 2022
matthiasschaub
added
the
priority:high
Should be addressed as soon as possible (next release)
label
Sep 20, 2022
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
matthiasschaub
commented
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the code, run all the tests and tested it manually a bit. The changes look good to me!
I left one minor comment.
I think what would be good to have are tests for the blocking
features. Maybe extending test_base_report
with those tests would be a good idea.
Gigaszi
approved these changes
Oct 11, 2022
matthiasschaub
changed the title
Report aggregation
Rewrite report aggregation of indicator to use mean value of indicator result class values
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority:high
Should be addressed as soon as possible (next release)
report
waiting for review
This pull request urgently needs a code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding issue
Closes #322, #263
Checklist
main
(e.g. throughgit rebase main
)