Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set flatten of properties to false #375

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 7, 2022

Description

Per default properties of the GeoJSON response are not flattend. Default of API request parameter flatten is False.

Corresponding issue

None

New or changed dependencies

  • none

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Maybe look over the examples and documentation once and search for the word flatten. Some examples could be set to the default value.

Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request_models.py has some flatten=True examples

@matthiasschaub
Copy link
Collaborator Author

Look good. Maybe look over the examples and documentation once and search for the word flatten. Some examples could be set to the default value.

Thanks for the review. I changed the value of the flatten parameter to represent the default value (Flase) in docs and API request examples.
Also I removed the unflatten function defintion and usage in the JavaScript files of the website.

@matthiasschaub matthiasschaub merged commit cbaa39f into main Jul 7, 2022
@matthiasschaub matthiasschaub deleted the make-flatten-default-false branch July 7, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants