Fixed visualization of extruded 1D meshes #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladotomov
approved these changes
Aug 13, 2024
najlkin
force-pushed
the
najlkin/fix-1D-mesh
branch
from
e959d00
to
3938827
Compare
najlkin
changed the title
|
@vladotomov , added a 1D test and waiting on approval of GLVis/data#6 . Update: approved by @tzanio |
najlkin
changed the title
tzanio
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes visualization of 1D meshes, which are incorrectly recognized as coarse meshes of quadratures, since 1D meshes are backed up before the extrusion (to be used with different representations of quadratures).
Reported by: @vladotomov
TODO: