Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to : Arp table drop the VPCS if there is some rows in arp-table #49

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Patch to : Arp table drop the VPCS if there is some rows in arp-table #49

merged 10 commits into from
Sep 8, 2023

Conversation

Raizo62
Copy link
Contributor

@Raizo62 Raizo62 commented Sep 8, 2023

issue #45

Raizo62 added 10 commits July 30, 2023 11:19
	- command.c :  static int show_ip(int argc, char **argv)
	- dump.c : int dmp_packet(const struct packet *m, const int flag)
…nts are unnecessary.

	- command.c : int run_set(int argc, char **argv)
	- command.c : j : int run_tracert(int argc, char **argv)
	- command6 : p : int run_ping6(int argc, char **argv)
	- packets.c : p : int upv4(pcs *pc, struct packet **m0)
	- tcp.c : tv : int tcp_close(pcs *pc, int ipv)
	dhcp.c : i : int dhcp_rebind(pcs *pc)
	dhcp.c : ok : int dhcp_rebind(pcs *pc)
	packets6.c : j : u_char *nbDiscovery(pcs *pc, ip6 *dst)
	readline : start : int findhistory(struct rls *rls, int start)
	- packetlife : i and data : int response(struct packet *m, sesscb *sesscb)
	- packetlife6 : i and data : int response6(struct packet *m, sesscb *sesscb)
	- remote.c : i and outbuf : int open_remote(int fdio, const char *destip, const u_short destport)
	- vpcs.c : void parse_cmd(char *cmdstr)
	readline : int main(int argc, char **argv)
	- command.c : int run_dhcp(int argc, char **argv)
	- utils.c : char *getkv(char *str)
	- help.c :
		-- int help_echo(int argc, char **argv)
		-- int help_hist(int argc, char **argv)
		-- int help_neighbor(int argc, char **argv)
		-- int help_version(int argc, char **argv)
		-- int help_shut(int argc, char **argv)
	- getopt.c : int arg_to_int(const char* arg, int min, int max, int defalt)
	- On MAC OS, the line "sprintf(buf + j * 3, "%2.2x:", pc->ipmac4[i].mac[j]);" crashs.
	- Perhaps that the snprintf of MACOS adds the '\0' after the last '01:' (the last byte of the mac address) and is out the array
@grossmj
Copy link
Member

grossmj commented Sep 8, 2023 via email

@grossmj
Copy link
Member

grossmj commented Sep 8, 2023

Thanks, I will review soon.

@grossmj grossmj merged commit c923aa9 into GNS3:master Sep 8, 2023
1 check passed
@grossmj
Copy link
Member

grossmj commented Sep 8, 2023

Great job, thank you 👍 I will release a new version of vpcs soon

@Raizo62 Raizo62 deleted the MacOS branch September 8, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants