From bc37f58aaa092960878059f751c1d2e7ea8dd690 Mon Sep 17 00:00:00 2001 From: Sae126V Date: Fri, 18 Aug 2023 14:45:09 +0000 Subject: [PATCH] [GT-184] Fix for minor improvements --- .../ManageAPICredentials/ManageAPICredentialsActions.php | 2 +- .../ManageUnusedAPICredentialsOptions.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/ManageAPICredentials/ManageAPICredentialsActions.php b/resources/ManageAPICredentials/ManageAPICredentialsActions.php index 8c556fac3..692dd80ab 100644 --- a/resources/ManageAPICredentials/ManageAPICredentialsActions.php +++ b/resources/ManageAPICredentials/ManageAPICredentialsActions.php @@ -352,7 +352,7 @@ private function getRenewalsBodyContent( $body = "Dear " . $user->getForename() . ",\n\n" . "The API credential associated with the following identifier\n" . - "registered at site $siteName has not been renewed from\n" . + "registered at site $siteName has not been renewed for\n" . "the last $elapsedMonths months and will be deleted if it " . "reaches $deletionThreshold months.\n\n"; diff --git a/resources/ManageAPICredentials/ManageUnusedAPICredentialsOptions.php b/resources/ManageAPICredentials/ManageUnusedAPICredentialsOptions.php index bf85cbe30..9399da9f3 100644 --- a/resources/ManageAPICredentials/ManageUnusedAPICredentialsOptions.php +++ b/resources/ManageAPICredentials/ManageUnusedAPICredentialsOptions.php @@ -57,7 +57,7 @@ public function getOptions() } $this->dryRun = isset($given['dry-run']); - $this->hasOptionProvided($given); + $this->tryToObtainDatetime($given); $this->setPropertyName(); $this->delete = $this->getValOption($given, 'deletion_threshold', 'd'); $this->warn = $this->getValOption($given, 'warning_threshold', 'w'); @@ -204,7 +204,7 @@ public function getThreshold() * @throws InvalidArgumentException When the user is NOT specifying * which datetime to obtain. */ - private function hasOptionProvided($given) + private function tryToObtainDatetime($given) { $this->isRenewalRequest = $this->getBoolOption($given, 'renewals', 'r');