Update shader tests after LLVM update #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
dstutt
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
This LGTM - but can you also add a comment in the commit message about why they're being disabled (upstream change means that the test will fail until it is propagated, so test is updated and disabled until the change it through).
You could add this when you squash and merge.
Test summary for commit 71e58f4CTS tests (Failed: 0/139021)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
approved these changes
Oct 12, 2023
Update tests affected by upstream change: [AMDGPU] Use absolute relocations when compiling for AMDPAL and Mesa3D llvm/llvm-project#67791 Tests would fail until they are propagated so they are also disabled in this patch. TODO: re-enable tests once everything has propagated.
petar-avramovic
force-pushed
the
absolute_relocations
branch
from
71e58f4
to
ce3abfe
Compare
Test summary for commit ce3abfeCTS tests (Failed: 0/139021)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests affected by upstream change:
[AMDGPU] Use absolute relocations when compiling for AMDPAL and Mesa3D
llvm/llvm-project#67791
Tests would fail until they are propagated so they are also disabled
in this patch. TODO: re-enable tests once everything has propagated.