Skip to content

Conversation

@Mcgode
Copy link

@Mcgode Mcgode commented May 6, 2023

The RPSL compilation command does not work on Windows, and seems to have been designed for Unix-like systems.

This PR fixes the command line for Windows, while keeping compatibility with Unix systems.
Addresses #28

@expenses
Copy link

expenses commented May 8, 2023

I think using the std::filesystem:path functions would be tidier: https://en.cppreference.com/w/cpp/filesystem/path/make_preferred. But I'm not sure what version of c++ RPS is targetting.

@Mcgode
Copy link
Author

Mcgode commented May 9, 2023

Indeed, thanks for the comment.

The RPS lib itself target C++11 but rpsl_explorer.hpp itself uses C++17 (and already uses std::filesystem::path in the same function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants