Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade USWDS to V3 #4460

Closed
3 of 6 tasks
btylerburton opened this issue Sep 12, 2023 · 7 comments
Closed
3 of 6 tasks

Upgrade USWDS to V3 #4460

btylerburton opened this issue Sep 12, 2023 · 7 comments
Assignees
@rshewitt
Labels
compliance Relating to security compliance or documentation

Comments

@btylerburton
Copy link
Contributor

btylerburton commented Sep 12, 2023 •
edited by rshewitt
Loading

User Story

In order to maintain our dependencies, datagovteam wants to upgrade USWDS to V3 due to a bug with V2 and the SASS library.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • GIVEN a repo using USWDS
    THEN it shall be upgraded to V3
    AND the site shall remain unchanged.

Background

Dependency scans flagged SASS for an upgrade but that is blocked by a bug in USWDS V2.

Security Considerations (required)

Leaving SASS unpatched long term could incur security risks

Sketch

uswds migration to v3 doc
@btylerburton btylerburton added the compliance Relating to security compliance or documentation label Sep 12, 2023
@hkdctol hkdctol moved this to 📔 Product Backlog in data.gov team board Sep 14, 2023
@nickumia-reisys nickumia-reisys mentioned this issue Oct 2, 2023
Closed
@rshewitt rshewitt self-assigned this Nov 14, 2023
@rshewitt rshewitt moved this from 📔 Product Backlog to 🏗 In Progress [8] in data.gov team board Nov 14, 2023
@rshewitt rshewitt mentioned this issue Nov 14, 2023
Merged
4 tasks
@rshewitt
Copy link
Contributor

datagov-11ty is using uswds v3

@rshewitt
Copy link
Contributor

  • uswds upgrade branch.
  • need to get the last cypress test to pass.
  • the ckan 2.10 & 2.10.1 tests are failing at requirement installation. action

@rshewitt
Copy link
Contributor

cypress tests are flaky but they've all passed after re-running them enough times so my updates work. need to get the ckan 2.10 & 20.1.1 test passing now.

@rshewitt
Copy link
Contributor

resolved issue with ckan tests by upgrading pip in the requirements

@rshewitt rshewitt mentioned this issue Nov 16, 2023
Merged
@rshewitt rshewitt moved this from 🏗 In Progress [8] to 📡 Blocked in data.gov team board Nov 16, 2023
@rshewitt rshewitt moved this from 📡 Blocked to 👀 Needs Review [2] in data.gov team board Nov 16, 2023
@btylerburton
Copy link
Contributor Author

cypress tests are still failling after 3 tries. i remember this test specifically being super flaky. might be time to rewrite it?

https://github.com/GSA/ckanext-dcat_usmetadata/actions/runs/6896494912/job/18763713494

@rshewitt
Copy link
Contributor

i've had to restart that one more than 3 times to get it to work. yeah I think rewriting it would be good

@rshewitt
Copy link
Contributor

it passed. https://github.com/GSA/ckanext-dcat_usmetadata/actions/runs/6896494912

@rshewitt rshewitt mentioned this issue Nov 20, 2023
Merged
4 tasks
@rshewitt rshewitt moved this from 👀 Needs Review [2] to ✔ Done in data.gov team board Nov 21, 2023
@hkdctol hkdctol closed this as completed Nov 22, 2023
@hkdctol hkdctol moved this from ✔ Done to 🗄 Closed in data.gov team board Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshewitt rshewitt

Labels
compliance Relating to security compliance or documentation
Projects
data.gov team board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hkdctol @rshewitt @btylerburton