Allow defining nightly ID from CI #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting nightly id externally. This is necessary for CI (GH Actions) to keep DAXXL id in sync with CI run id.
eigenraven
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate nightly ID is set by GH Actions, however this ID isn't passed to DAXXL, which means if a nightly CI job fails, the nightly (job) ID still increases, while the ID in
gtnh-assets.jsonis unaltered. This is most noticeable in the naming of the generated changelog files whose names no longer correspond to the correct nightly release zips.This PR fixes this by adding a new cmdline argument which allows setting the numeric nightly ID directly. This includes validation to make sure that the new ID is always larger than the last nightly.