Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate changelog between last release and current nightly #177

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

wlhlm
Copy link
Member

@wlhlm wlhlm commented Nov 10, 2024

Generate changelog between last release and current nightly. I think that's a bit more informative than the changelog from one nightly version to the previous nightly as those usually only include a handful of changes at most.

Drawback is that if there's a new release, the nightly-non-nightly changelog for the old release will stick around (and stop getting updated) and eventually need manual cleanup. That won't happen that often and should be manageable.

Fixes a bug with the --previous-release-name parameter of gtnh.cli.generate_changelog which made it not work at all.

@Alexdoru
Copy link
Member

The changelog from nightly to nightly is very useful to track down bugs that appear in between versions and that are caused by cross mod interactions (so you can't just open one project and look at the git history of that one project). Please don't delete the nightly to nightly changelog, you can add the last stable to current nightly changelog as a separate second file.

@wlhlm
Copy link
Member Author

wlhlm commented Nov 10, 2024

Uhh, I haven't touched the nightly-nightly changelogs. This just adds another type.

@Alexdoru
Copy link
Member

Good

@boubou19 boubou19 merged commit 1fab55c into master Nov 17, 2024
1 check passed
@boubou19 boubou19 deleted the generate-nightly-non-nightly-changelog branch November 17, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants