-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Structure checks to add error hinting #3254
base: master
Are you sure you want to change the base?
Conversation
…at inherit from MTEDrillerBase
could you take advantage of this PR to change hint blocks to have a number instead of dots? it would improve the readability a lot |
I took some time and looked into this. I have a test branch where I rendered text on top of the blocks. It turned out okay, but I think the better way is to just replace the hint block textures here. Not sure if someone who is a better artist wants to take a crack at that. |
Changes
Implements Error Hinting on GT Multis
Implements the
couldBeValid(...)
function to mostIStructureElement<T>
instances in GT. This allows error hinting to show the player blocks that will fail the structure check. This is a new toggleable option on the hologram projector. See GTNewHorizons/StructureLib#31 for more information on error hinting.Sample Usage
Highlights missing blocks
Highlights hatches that are not allowed
Fusion Reactor doesn't accept low tiered hatches
Testing/Verification
Since this is separate from the structure check, it should not cause any problems with multiblocks forming. I have gone through the following multiblocks and verified expected behavior.
For the following I verified that with a lone controller, all of the blocks are invalid and that with a formed multiblock none of them are.
MTEDrillerBase
had a more permissive structure check than required due to (I think) a bug in the structure code. Fixing this bug to prevent multiblocks with extra, unrequired hatches from forming.checkMachine
and isn't part of the StructureLib structure check.ME Output Hatch is incorrectly listed as tier too low (but still forms).FixedFurther testing in progress.
Improves some structure checks
Naquadah Fuel Refinery
Changed structure check to use the
ofBlocksTiered
primitive instead of implementing it again.Breaking Changes (due to fixing structure code)
If these were intended, let me know and I will revert them.
MTEDrillerBase
multiblocks structure check to actually use thegetAllowedHatches
list instead of allowing all hatches. These could previously form with muffler hatches and data access hatches ...why?Requires
Version of StructureLib with GTNewHorizons/StructureLib#31 merged.