Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UUIDs as keys instead of player instances in KeyTracking state map #4

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Use UUIDs as keys instead of player instances in KeyTracking state map #4

merged 3 commits into from
Nov 16, 2023

Conversation

tth05
Copy link

@tth05 tth05 commented Nov 16, 2023

Currently, this Map leaks player instances and therefore WorldClient instances.

@Pelotrio Pelotrio requested a review from a team November 16, 2023 10:42
@Dream-Master Dream-Master merged commit 7fc156b into GTNewHorizons:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneEyeMaker OneEyeMaker OneEyeMaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tth05 @OneEyeMaker @Dream-Master