Fix boiler structure causing a ClassCastException #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't feel like the right way to fix it. The problem comes from blockrenderer using the wrong context object, and this PR tries to hide the issue by making the structure not use the context object. This is at best a bandaid fix. It works, but uh if there is any alternative we could try I wouldn't merge this. |
|
Ah okay, with that info I see a nice and simple way to fix it in blockrenderer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitionByfeeds the element into adeferelement which does not play nice withIMultiblockInfoContainerand will cause an incorrect cast. This accomplishes the same thing without causing the aforementioned issue.Closes: GTNewHorizons/GT-New-Horizons-Modpack#16421