Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fromTo and friends return VWord when appropriate #1436

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Make fromTo and friends return VWord when appropriate #1436

merged 1 commit into from
Sep 17, 2022

Commits on Sep 16, 2022

  1. Make fromTo and friends return VWord when appropriate 

    Previous, `fromTo` and related functions would always return a `VSeq`. If the
type happened to be a `Bit`, this would violate the internal invariant that
sequences of `Bit`s are always represented with `VWord`s, leading to the panics
observed in #1435. This patch fixes the issue by using the `mkSeq` smart
constructor, which chooses between `VWord` and `VSeq` depending on the sequence
type.

Fixes #1435.
    @RyanGlScott
    RyanGlScott committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    84f11e2 View commit details
    Browse the repository at this point in the history