Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc-gen CI to not fail on the existsence of a non-mergeable PR. #1768

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

kquick
Copy link
Member

@kquick kquick commented Nov 14, 2024

The doc generation run as part of CI attempts to build and deploy a version of the docs for each PR (which allows inspection of doc updates for a PR before it lands). The docs build is done for the expected marge result (merge_commit_sha) of the PR, but if the PR has a merge conflict with the main branch, then the value for this field will be null, and thus this CI script will fail.

This change modifies the doc generation CI process to skip PR's that are in this state.

Copy link
Contributor

@sauclovian-g sauclovian-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kquick kquick changed the title Initial commit with no actual changes to validate failure mode Fix doc-gen CI to not fail on the existsence of a non-mergeable PR. Nov 14, 2024
@kquick kquick merged commit 9821aa9 into master Nov 14, 2024
49 checks passed
@kquick kquick deleted the build_doc_merge_fail branch November 14, 2024 22:06
sauclovian-g added a commit that referenced this pull request Nov 14, 2024
sauclovian-g added a commit that referenced this pull request Nov 14, 2024
For the record, this change was rebased across the CI fixes from #1768.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants