Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to the modules system. #959

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Bug fixes to the modules system. #959

merged 2 commits into from
Nov 12, 2020

Commits on Nov 11, 2020

  1. Bug fixes to the modules system.

    This fixes #796.
    It also fixes the @bboston7's example on #883, but not the original
    example in #883.   The issue there is that `asdf` function generates
    a constraint only involving the module parameter.
    
    Normally we don't try to solve constraint that don't mention a schema's
    parameters, because they can always be solved "later", and hopefully with
    more things instantiated.
    
    The weird thing in this case is that the schema adds *local" constraint to
    the module parameters, but we end up ignoring these.
    yav committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    192b25c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Be more aggressive when checking signatures.

    When checking a signature we try to solve sub-goals that mention any
    of the variables mentioned in the signature's assumptions.  We do this
    because these assumptions are local, and if the assumption is not solved
    in the current context, we may not be able to solve it later.
    
    This is OK if the goal does not contain free variables.  If it does,
    things are a bit flaky as we may reject some programs and accept others
    depending on in what order things happened to be instnatiated
    yav committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    30928f8 View commit details
    Browse the repository at this point in the history