Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.8, drop GHC 9.2 #270

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

langston-barrett
Copy link
Contributor

No description provided.

@RyanGlScott
Copy link
Contributor

The test suite likely won't compile without first resolving kquick/kvitable#2.

@langston-barrett
Copy link
Contributor Author

Hmm, it looks like the diagnostics in that issue only consist of warnings, perhaps we can just bump the base bound and ignore the warnings until a more satisfying resolution is found?

@langston-barrett langston-barrett marked this pull request as ready for review February 22, 2024 18:01
cabal.project Outdated Show resolved Hide resolved
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nix-ci.yml also needs to be updated to add GHC 9.8, which will necessitate flake.nix changes (essentially you can duplicate the changes in kquick/kvitable@4b4043b).

@langston-barrett langston-barrett force-pushed the lb/ghc-9.8 branch 2 times, most recently from b85a510 to 936fae2 Compare February 28, 2024 14:37
@langston-barrett
Copy link
Contributor Author

At b85a510#r139131670, @kquick said:

What do you think of leaving the older GHC's, but marking them (via comment) as "optimistic builds; no longer supported"? My thinking here is that (a) unlike using regular ubuntu packages, the locking provided by flakes makes it easy to access these older versions, (b) these builds are pretty fast and lowe cost, and (c) this can let us explicitly know when our trailing horizon is updated.

I don't have a strong stance here, if we do go forward with this we should update doc/development.md and the README to reflect the new policy.

@kquick
Copy link
Member

kquick commented Feb 28, 2024

We wouldn't need to change the docs because we would still have the same policy of committing to support the recent 3-version window. This would just be adding the older GHC builds into the nix ci to inform us regarding the trailing support horizon.

@langston-barrett langston-barrett merged commit 61306f7 into GaloisInc:master Feb 28, 2024
26 checks passed
@langston-barrett langston-barrett deleted the lb/ghc-9.8 branch February 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants