Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make re-assembly more robust #88

Open
travitch opened this issue May 10, 2021 · 0 comments
Open

Make re-assembly more robust #88

travitch opened this issue May 10, 2021 · 0 comments

Comments

@travitch
Copy link
Contributor

Currently, renovate re-assembles basic blocks that the caller has not changed to produce the bytes that will be written back to the new binary. We could instead just copy the bytes from the original, which would be robust against re-assembly bugs (especially relevant for the x86_64 backend).

We would need to be a bit careful here to ensure that this is only applied to completely unchanged blocks (i.e., that the block successor does not need to change).

It isn't clear that this would be a significant win, but it could avoid some annoying re-assembly problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant