-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use Tuple instead of Struct in saw-remote-api backend #1162
Conversation
Does this imply that we should rename the data structures corresponding to the |
I'm re-reading @atomb's original comments on the matter. The impression I got was the things which are not inherently LLVM-related should prefer the more generic "tuple", while things that are LLVM specific should be free to use the terminology/type names/etc from LLVM. To that end, I think it's right to rename the |
@@ -44,7 +44,7 @@ instance FromJSON cryptolExpr => FromJSON (CrucibleSetupVal cryptolExpr) where | |||
TagNullValue -> pure NullValue | |||
TagCryptol -> CryptolExpr <$> o .: "expression" | |||
TagArrayValue -> ArrayValue <$> o .: "elements" | |||
TagStructValue -> StructValue <$> o .: "fields" | |||
TagTupleValue -> TupleValue <$> o .: "elements" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this isn't the officially sanctioned source of documentation anymore, but I'd find it helpful if old-SAW.rst
were updated to reflect this change to the SAW remote API, especially in light of #1121.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. And, yes, the idea was that language-agnostic stuff would use tuple/record names whereas language-specific stuff would use language-specific names (like struct
). At the moment, that distinction is somewhat academic, but once the Java bindings are in place I think it'll be more meaningful.
Use the more generic "tuple" instead of "struct" notion of value in the server backend (while keeping "struct" in the llvm-interface). See #1031