Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goal_when_num and goal_num_ite #986

Merged
merged 3 commits into from
Jan 4, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions intTests/test_goal_num_ite/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
test.bc : test.c
clang -O0 -c -emit-llvm -o test.bc test.c

Binary file added intTests/test_goal_num_ite/test.bc
Binary file not shown.
14 changes: 14 additions & 0 deletions intTests/test_goal_num_ite/test.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#include<stdint.h>

void g(uint64_t* a) {
*a = 2*(*a);
};

void h(uint64_t* a) {
*a = 3*(*a);
};

void f(uint64_t* x) {
g(x);
h(x);
};
46 changes: 46 additions & 0 deletions intTests/test_goal_num_ite/test.saw
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
m <- llvm_load_module "test.bc";

let f_spec = do {
xp <- llvm_alloc (llvm_int 64);
x <- llvm_fresh_var "x" (llvm_int 64);
llvm_points_to xp (crucible_term x);
llvm_execute_func [xp];
llvm_points_to xp (crucible_term {{ 6*x }});
};

let g_spec = do {
xp <- llvm_alloc (llvm_int 64);
x <- llvm_fresh_var "x" (llvm_int 64);
llvm_points_to xp (crucible_term x);
llvm_execute_func [xp];
llvm_points_to xp (crucible_term {{(2*x):[64]}});
};

let h_spec = do {
xp <- llvm_alloc (llvm_int 64);
x <- llvm_fresh_var "x" (llvm_int 64);
llvm_points_to xp (crucible_term {{x}});
llvm_precond {{ x > 1 }};
llvm_execute_func [xp];
llvm_points_to xp (crucible_term {{(3*x):[64]}});
};

g_ov <- llvm_verify m "g" [] false g_spec z3;
h_ov <- llvm_verify m "h" [] false h_spec z3;

enable_experimental;

// we get two verification conditions: on for the precondition of h, and one for the postcondition of f
// the override precondition of h is violated, but if we assume it's unsat then verification succeeds:
llvm_verify m "f" [g_ov, h_ov] false f_spec
(goal_num_ite 0
assume_unsat
w4);

// on the other hand, if we provide the wrong goal number, then it fails.
fails (
llvm_verify m "f" [g_ov, h_ov] false f_spec
(goal_num_ite 1
assume_unsat
w4)
);
4 changes: 4 additions & 0 deletions intTests/test_goal_num_ite/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
set -e

$SAW test.saw

16 changes: 15 additions & 1 deletion src/SAWScript/Builtins.hs
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ print_goal :: ProofScript ()
print_goal =
withFirstGoal $ \goal ->
do opts <- getTopLevelPPOpts
printOutLnTop Info ("Goal " ++ goalName goal ++ ":")
printOutLnTop Info ("Goal " ++ goalName goal ++ " (goal number " ++ (show $ goalNum goal) ++ "):")
printOutLnTop Info (scPrettyTerm opts (unProp (goalProp goal)))
return ((), mempty, Just goal)

Expand Down Expand Up @@ -627,13 +627,27 @@ goal_insert (Theorem (Prop t) _stats) =
let goal' = goal { goalProp = Prop body' }
return ((), ProofState (goal' : goals') concl stats timeout)

goal_when_num :: Int -> ProofScript () -> ProofScript ()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: goal_num_when, consistent with goal_num_ite

goal_when_num n script =
StateT $ \s ->
case psGoals s of
g : _ | ((goalNum g) == n) -> runStateT script s
_ -> return ((), s)

goal_when :: String -> ProofScript () -> ProofScript ()
goal_when str script =
StateT $ \s ->
case psGoals s of
g : _ | str `isInfixOf` goalName g -> runStateT script s
_ -> return ((), s)

goal_num_ite :: Int -> ProofScript SV.SatResult -> ProofScript SV.SatResult -> ProofScript SV.SatResult
goal_num_ite n s1 s2 =
StateT $ \s ->
case psGoals s of
g : _ | goalNum g == n -> runStateT s1 s
_ -> runStateT s2 s

-- | Bit-blast a proposition and check its validity using ABC.
proveABC :: ProofScript SV.SatResult
proveABC = do
Expand Down
11 changes: 11 additions & 0 deletions src/SAWScript/Interpreter.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1191,6 +1191,17 @@ primitives = Map.fromList
[ "Run the given proof script only when the goal name contains"
, "the given string."
]
, prim "goal_num_ite" "Int -> ProofScript SatResult -> ProofScript SatResult -> ProofScript SatResult"
(pureVal goal_num_ite)
Experimental
[ "If the goal number is the given number, runs the first script."
, "Otherwise runs the second script" ]
, prim "goal_when_num" "Int -> ProofScript () -> ProofScript ()"
(pureVal goal_when_num)
Experimental
[ "Run the given proof script only when the goal number is the"
, "the given number."
]
, prim "print_goal" "ProofScript ()"
(pureVal print_goal)
Current
Expand Down