Add JSON types #61
Merged
Add JSON types #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms1111
commented
Oct 31, 2020
ms1111
commented
Oct 31, 2020
Define explicit types for legal plain JSON values to avoid double-deserialization shenanigans. Fixes #59.
hardy613
added
documentation
Conflicts: from_json/as.ts serializable.ts to_json/recursive.ts
hardy925
previously approved these changes
Nov 9, 2020
hardy925
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#59 - JsonNode type
Description
Define explicit types for legal plain JSON values to avoid double-deserialization shenanigans.
Fixes #59.
Proposed changes in this PR
Adds JsonValue and JsonObject types to make ToJsonStrategy and FromJsonStrategy more specific.
Things to look at