Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: user guide for publishing via Modal #551

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

hholb
Copy link
Contributor

@hholb hholb commented Oct 31, 2024

Resolves: #547

Overview

This PR adds a page to the user guide detailing the process of publishing a Garden using Modal. The new page details the flow @shane-jung added in #215.

Testing

Check out the new page locally with mkdocs serve

Documentation

It's all docs!


📚 Documentation preview 📚: https://garden-ai--551.org.readthedocs.build/en/551/

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (583ec3a) to head (b34a34e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          38       38           
  Lines        2407     2407           
=======================================
  Hits         1804     1804           
  Misses        603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hholb hholb marked this pull request as ready for review October 31, 2024 14:43
Copy link
Member

@OwenPriceSkelly OwenPriceSkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first pass, thanks for jumping on it!

couple of things I didn't mention in other comments: I think we should add the new docs to the nav bar so it shows up when I click User Guide (see mkdocs.yml) and I think we should disclaim at the beginning that this is an experimental / limited beta feature and users should reach out if they're interested in trying it

@hholb hholb requested a review from OwenPriceSkelly October 31, 2024 18:51
Copy link
Member

@OwenPriceSkelly OwenPriceSkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hholb hholb merged commit 0244c64 into main Nov 4, 2024
5 checks passed
@hholb hholb deleted the hholb/modal-pub-docs branch November 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Modal publication
2 participants