-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add the optional argument of --reach to certain checks #210
base: master
Are you sure you want to change the base?
Conversation
addresses issue #205 |
Hello @corlettim and @schultzh, please make sure that you update this branch with the new content that is in the master branch. I'm hoping that you find that merging in this fashion will resolve some of the issues that you were facing with builds not working correctly. Let me know what you discover! |
@gkapfham @corlettim Note that this PR's body does not have a valid versioning sentence. It should probably match the "minor" regex mentioned in the README, and so the word "small" should be dropped. If it should be considered a "patch" change, instead of "feature" you should use "update" or "change", but since this is a new feature it should probably be a minor version increment. |
Thanks @Michionlion, I fixed the phrasing. |
…ator/gatorgrader into argument/optional-advanced-tag
--reach
to certain checks
This PR is a feature that adds the
--reach
argument to all of the checks. This PR must work in conjunction with the Feature/reach goal PR for the GatorGradle plugin.We thought it was an important feature to add because we have noticed that some students need a reach goal in mind to push them or challenge them a little more in the classroom. We are still unsure of how to connect this to the correct output if the user completes or does not complete this check. Further research and testing will assist with this. Consequently, there is still more work that needs to go in to this PR and topic.
Fixes #205
Notes: @gkapfham added a description that follows the pr-tag-release standard. Also, @gkapfham removed the following phrases from the start of this PR's description:
@corlettim and @schultzh if it is not possible to make this work for all of the checks, then can you please list the ones for which this will not work and explain why it won't work for each one?