Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add the optional argument of --reach to certain checks #210

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
1ce5a91
add the optional argument of to certain checks
corlettim Oct 31, 2019
4adfae8
add the marker of a circle for the reach goal
corlettim Nov 1, 2019
c099fea
Merge branch 'master' into argument/optional-advanced-tag
corlettim Jan 31, 2020
00f1dc1
add optional reach argument to confirm file exists
corlettim Feb 5, 2020
382cd12
add optional reach argument to count command output
corlettim Feb 5, 2020
36b6896
add optional reach argument to count commits
corlettim Feb 5, 2020
f94d0a8
add reach to paragraphs check and remove whitespace
corlettim Feb 5, 2020
ca493a2
Merge branch 'argument/optional-advanced-tag' of github.com:GatorEduc…
corlettim Feb 5, 2020
436a3ac
add optional group equal to parse
corlettim Feb 5, 2020
9877d33
add reach to return statement
corlettim Feb 5, 2020
0022a70
add reach to count markdown tags
corlettim Feb 5, 2020
5c562da
change multiline comment to reach instead of advanced
corlettim Feb 5, 2020
6e329d7
add reach to paragraph words
corlettim Feb 5, 2020
01d1c0a
add reach to execute command
corlettim Feb 5, 2020
85e6d8f
add reach to list checks
corlettim Feb 5, 2020
84afe04
add reach to match file fragment
corlettim Feb 5, 2020
226ab02
add reach to match command regex
corlettim Feb 5, 2020
5a62619
add reach to match file regex
corlettim Feb 5, 2020
a54690f
declare reach in necessary checks
corlettim Feb 5, 2020
1702013
remove reach in return for all checks
corlettim Feb 5, 2020
f5ce127
comment out all assignments of reach
corlettim Feb 5, 2020
5afc4eb
remove extra space in List Checks
corlettim Feb 5, 2020
095b3ea
run black on constants.py
corlettim Feb 9, 2020
f066426
fix assertion errors for new lines to equal 3 instead of 2
corlettim Feb 9, 2020
93600cf
declare reach in ConfirmFileexists
corlettim Feb 10, 2020
ffc4f69
fix CountFileExist test cases to check reach
corlettim Feb 10, 2020
64562e0
revert test cases back to passing
corlettim Feb 11, 2020
e3140bb
declare reach=False in test_invoke
corlettim Feb 20, 2020
09a4531
add reach=False for count commits in invoke
corlettim Feb 20, 2020
2ae541e
add reach=False for count commits in invoke
corlettim Feb 20, 2020
fe1ea36
declare reach in count file paragraphs for invoke
corlettim Feb 20, 2020
861f438
reach declare in count file words and equal to false in invoke
corlettim Feb 20, 2020
0b6e2d6
declare reach equal to false in invoke for markdown tags
corlettim Feb 20, 2020
f3e1152
declare reach to be false in invoke for multi line
corlettim Feb 20, 2020
b0a83f1
declare reach to be false in invoke for paragraph words
corlettim Feb 20, 2020
0f9cf70
declare reach in single line
corlettim Feb 20, 2020
1b11845
declare reach in invoke to be false for execute command
corlettim Feb 20, 2020
70820f3
reach declared to be false in invoke for confirm file exists
corlettim Feb 20, 2020
de2b425
declare reach to be false in invoke for command frag
corlettim Feb 20, 2020
5da55d9
declare reach to be false in invoke for command reg
corlettim Feb 20, 2020
6b28711
declare reach to be false and return in invoke for file frag
corlettim Feb 20, 2020
b54948c
declare reach to be false and return in invoke for file reg
corlettim Feb 20, 2020
b602b90
run black to reformat in check files
corlettim Feb 20, 2020
0722b35
removal of reach in certain checks that fail to hold the declaration
corlettim Feb 21, 2020
980cad8
add metavar for execute command and command output
corlettim Feb 27, 2020
95da735
remove print line
corlettim Feb 27, 2020
c3bc372
remove print lines
corlettim Feb 27, 2020
b2a7fd8
change assertion lines for command output
corlettim Feb 28, 2020
4260cb1
fix pylint
corlettim Feb 28, 2020
0e9d65d
add reach for match file regex
corlettim Feb 28, 2020
a6bdead
add reach for match command regex
corlettim Feb 28, 2020
1db21ac
run black for format fix
corlettim Feb 28, 2020
3b554b3
add a new data to test case to command output
corlettim Feb 28, 2020
265d8a7
run black on test command output
corlettim Feb 28, 2020
e8494a2
add parameterized test to count commits
corlettim Feb 28, 2020
52d60ee
reformat
corlettim Feb 28, 2020
2f031ad
fix flake8 errors with whitespace
corlettim Feb 28, 2020
ccecccd
add reach to count file lines test cases
corlettim Feb 28, 2020
a422de1
add tests to count file paragraphs
corlettim Mar 10, 2020
43030a4
add reaqch to test count file words
corlettim Mar 10, 2020
8c96625
add reach to test cases
corlettim Mar 10, 2020
994304d
add reach case to count filelines
corlettim Mar 10, 2020
a0b4c13
add reach case to count file paragraphs
corlettim Mar 10, 2020
f67f89b
add reach case to paragraph words
corlettim Mar 10, 2020
685dd6d
add reach case to count single line comments
corlettim Mar 10, 2020
030f90d
add reach case to test match command frag
corlettim Mar 10, 2020
c5f4346
add reach case to test match file frag
corlettim Mar 10, 2020
a1f3703
add reach case to test match file reg
corlettim Mar 10, 2020
bc06ab0
add more reach cases for test count markdown tags
corlettim Mar 10, 2020
7e14431
Merge branch 'master' into argument/optional-advanced-tag
corlettim Oct 20, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ requests = ">=2.20.0"
commonmark = "*"
num2words = "*"
pluginbase = "*"
black = "*"
corlettim marked this conversation as resolved.
Show resolved Hide resolved

[dev-packages]
pylint = "*"
Expand Down
156 changes: 125 additions & 31 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions gator/checks/check_ConfirmFileExists.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,17 @@ def get_parser():

# Optional Named Checker Arguments {{{

optional_group = parser.add_argument_group("optional check arguments")

# None required for this checker
# REACH: allows for a students to have a reach goal in their lab/practical
# REQUIRED? No
optional_group.add_argument(
"--reach",
help="creates a higher goal for students to potentially reach",
default=False,
action="store_true",
)

# }}}
return parser
Expand All @@ -63,4 +73,5 @@ def act(main_parsed_arguments, check_remaining_arguments):
# point since argparse will exit the program if a command-line argument is not provided
file = check_parsed_arguments.file
directory = check_parsed_arguments.directory
# reach = check_parsed_arguments.reach
return [invoke.invoke_file_in_directory_check(file, directory)]
10 changes: 10 additions & 0 deletions gator/checks/check_CountCommandOutput.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,15 @@ def get_parser():
action="store_true",
)

# REACH: allows for a students to have a reach goal in their lab/practical
# REQUIRED? No
optional_group.add_argument(
"--reach",
help="creates a higher goal for students to potentially reach",
default=False,
action="store_true",
)

# }}}
return parser

Expand All @@ -73,4 +82,5 @@ def act(main_parsed_arguments, check_remaining_arguments):
command = check_parsed_arguments.command
count = check_parsed_arguments.count
exact = check_parsed_arguments.exact
# reach = check_parsed_arguments.reach
return [invoke.invoke_all_command_count_checks(command, count, exact)]
10 changes: 10 additions & 0 deletions gator/checks/check_CountCommits.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ def get_parser():
action="store_true",
)

# REACH: allows for a students to have a reach goal in their lab/practical
# REQUIRED? No
optional_group.add_argument(
"--reach",
help="creates a higher goal for students to potentially reach",
default=False,
action="store_true",
)

# }}}
return parser

Expand All @@ -63,6 +72,7 @@ def act(main_parsed_arguments, check_remaining_arguments):
# point since argparse will exit the program if the command-line argument is not provided
count = check_parsed_arguments.count
exact = check_parsed_arguments.exact
# reach = check_parsed_arguments.reach
return [
invoke.invoke_commits_check(constants.paths.Current_Directory, count, exact)
]
9 changes: 9 additions & 0 deletions gator/checks/check_CountFileLines.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ def get_parser():
default=False,
action="store_true",
)
# REACH: allows for a students to have a reach goal in their lab/practical
# REQUIRED? No
optional_group.add_argument(
"--reach",
help="creates a higher goal for students to potentially reach",
default=False,
action="store_true",
)

# }}}
return parser
Expand All @@ -83,6 +91,7 @@ def act(main_parsed_arguments, check_remaining_arguments):
file = check_parsed_arguments.file
directory = check_parsed_arguments.directory
exact = check_parsed_arguments.exact
# reach = check_parsed_arguments.reach
return [
invoke.invoke_all_count_checks(
count, file, directory, constants.markers.Nothing, exact
Expand Down
Loading