Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lapis): regex filtering for string columns #898 #902

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

JonasKellerer
Copy link
Contributor

@JonasKellerer JonasKellerer commented Aug 21, 2024

resolves #898
resolves #901

Users can now filter for all string columns using regular expressions. Users can decide between a string equals filter using the current notation "myMetadata": "searchedValue". When users want to search using regex, they need to append $regex to the metadata field name eg. "myMetadata$regex": "someRegex".

The string columns which support regex search can be configured using the option lapisAllowsRegexSearch. Per default it is turned off.

PR Checklist

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lapis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:47pm

@fengelniederhammer fengelniederhammer force-pushed the 898-regex-search-implement-filter-fields branch from 3f30e6f to c74ab2a Compare August 21, 2024 13:47
@fengelniederhammer fengelniederhammer marked this pull request as ready for review August 21, 2024 14:00
@fengelniederhammer fengelniederhammer merged commit d146717 into main Aug 21, 2024
9 checks passed
@fengelniederhammer fengelniederhammer deleted the 898-regex-search-implement-filter-fields branch August 21, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex search: configuration which columns should support it Regex search: implement filter fields
2 participants