Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize filter for displayed segments/mutation #486

Open
JonasKellerer opened this issue Nov 5, 2024 · 1 comment
Open

Optimize filter for displayed segments/mutation #486

JonasKellerer opened this issue Nov 5, 2024 · 1 comment
Labels
components Regarding the components

Comments

@JonasKellerer
Copy link
Collaborator

In getFilteredMutationsOverTimeData.ts we filter for segments. There we loop through all segments to find if a segment was selected or not. This can be more efficient by replacing the array of DisplayedSegment with an object of the shape { [segment]: value }.
The same is true for the DisplayedMutationType.

Check first if it is feasible to convert the arrays to objects. Then implement it.
@JonasKellerer JonasKellerer added the components Regarding the components label Nov 5, 2024
@JonasKellerer JonasKellerer mentioned this issue Nov 5, 2024
Merged
2 tasks
@JonasKellerer
Copy link
Collaborator Author

Also check, if it is really an optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
components Regarding the components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonasKellerer