Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check how we could implement a map component #553

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fengelniederhammer
Copy link
Collaborator

resolves #548

Summary

What I found out about the data itself: There are two widely used data formats:

I found https://github.com/markmarkoh/datamaps/tree/master/src/js/data, which has map data for many countries (in the topojson format). The repo itself looks pretty unmaintained, but most countries don't change that often. Taking the map data should still be ok.

I've looked into https://www.npmjs.com/package/chartjs-chart-geo, but it wasn't really satisfying. I couldn't warp my head around how to properly configure the projections to make the maps look good (centered, proportions not distorted too much).

The current approach is based on https://leafletjs.com/. It seems quite powerful and very customizable.

The main open points to me are:

  • Do we provide the maps? Do we offer a possibility to let users plug in the maps?
    • The maps are quite significant in size (at least in browser terms): Usually around
  • How do we map the values from LAPIS to the states in the maps? We don't have control over the LAPIS instance -> we probably need a way to let the user provide a mapping between lapis field values and state names in the maps.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:20pm

Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map: sketch a solution
1 participant