Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czech accented letters #193

Closed
a1346054 opened this issue Jul 10, 2018 · 5 comments
Closed

Czech accented letters #193

a1346054 opened this issue Jul 10, 2018 · 5 comments

Comments

@a1346054
Copy link
Contributor

Letters like these work:

ýáíéú

Still need these to fully support Czech language:

ěščřžňťďů

Thank you. The app is awesome.

@rom1v
Copy link
Collaborator

rom1v commented Jul 10, 2018

@a1346054
Copy link
Contributor Author

Looks like it needs addCombining('\u030C', ACCENT_CARON);

because Caron is the thing needed for Czech https://en.wikipedia.org/wiki/Caron

@a1346054
Copy link
Contributor Author

a1346054 commented Jul 10, 2018

And also addCombining('\u030A', ACCENT_RING_ABOVE);

for the ů character https://en.wikipedia.org/wiki/Ring_(diacritic)

@a1346054
Copy link
Contributor Author

I don't know how to do programming but I think I understand your code. I will try to make a pull request.

@a1346054
Copy link
Contributor Author

a1346054 commented Jul 10, 2018

I created #194 but I do not know if it works. Your code is very easy to read though. I simply copied your code and changed function names and added the letters I need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants