Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissociate virtual display size and capture size #5506

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Commits on Nov 21, 2024

  1. Dissociate virtual display size and capture size

    Allow capturing virtual displays at a lower resolution using
    -m/--max-size.
    
    In the original implementation in #5370, the virtual display size was
    necessarily the same as the capture size. The --max-size value was only
    allowed to determine the virtual display size when no explicit size was
    provided.
    
    Since the dpi was scaled down accordingly, it is often better to create
    a virtual display at the target capture size directly. However, not
    everything is rendered according to the virtual display DPI. For
    example, a page in Firefox is rendered too big on small virtual
    displays. Thus, it makes sense to be able create a virtual display at a
    given size, and capture it at a lower resolution with --max-size. This
    is now possible using OpenGL filters.
    
    Therefore, change the behavior of --max-size for virtual displays:
     - --max-size does not impact --new-display without size argument
       anymore (the virtual display size is the main display size);
     - it is used to limit the capture size (whether an explicit size is
       provided or not).
    
    This new behavior is consistent with main display capture.
    
    Refs #5370 comment <#5370 (comment)>
    Refs #5370 <#5370>
    PR #5506 <#5506>
    rom1v committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    264110f View commit details
    Browse the repository at this point in the history