Fix dlang#2691: Use same structure for managed and unmanaged path

Currently, we issue a warning asking people to migrate, but the migrated
path is not actually recognized. It was suggested in the issue to ignore
this warning for add-path. However, as add-path is a rather low-level
use, I think it is better to impose the same condition for managed and
unmanaged path, in order to be able to provide the same guarantees.
For example, once we move to reading version from the path,
we can provide the same speedups for add-path users.
We can also make sure that add-path users don't have surprises when
dealing with packages that expect a certain structure outside their
directory, such as arsd and ae.
Some tests were updated with the new path, however, as many will likely
be rewritten with the new test framework, and a lot of tests are affected,
not all of them were updated, providing coverage for the old and new
code alike.

source/dub/packagemanager.d

@@ -1335,7 +1335,7 @@ package struct Location {
 
 			// Managed structure: $ROOT/$NAME/$VERSION/$NAME
 			// This is the most common code path
-			else if (mgr.isManagedPath(path)) {
+			else {
 				// Iterate over versions of a package
 				foreach (versdir; iterateDirectory(pack_path)) {
 					if (!versdir.isDirectory) continue;

test/issue1024-selective-upgrade.sh

@@ -2,13 +2,13 @@
 
 . $(dirname "${BASH_SOURCE[0]}")/common.sh
 cd ${CURR_DIR}/issue1024-selective-upgrade
-echo "{\"fileVersion\": 1,\"versions\": {\"a\": \"1.0.0\", \"b\": \"1.0.0\"}}" > main/dub.selections.json
-$DUB upgrade --bare --root=main a
+echo "{\"fileVersion\": 1,\"versions\": {\"a\": \"1.0.0\", \"b\": \"1.0.0\"}}" > main/~master/main/dub.selections.json
+$DUB upgrade --bare --root=main/~master/main/ a
 
-if ! grep -c -e "\"a\": \"1.0.1\"" main/dub.selections.json; then
+if ! grep -c -e "\"a\": \"1.0.1\"" main/~master/main/dub.selections.json; then
 	die $LINENO "Specified dependency was not upgraded."
 fi
 
-if grep -c -e "\"b\": \"1.0.1\"" main/dub.selections.json; then
+if grep -c -e "\"b\": \"1.0.1\"" main/~master/main/dub.selections.json; then
 	die $LINENO "Non-specified dependency got upgraded."
 fi

test/issue564-invalid-upgrade-dependency.sh

@@ -2,7 +2,4 @@
 
 . $(dirname "${BASH_SOURCE[0]}")/common.sh
 cd ${CURR_DIR}/issue564-invalid-upgrade-dependency
-rm -rf a-1.0.0/.dub
-rm -rf a-1.1.0/.dub
-rm -rf main/.dub
-${DUB} build --bare --compiler=${DC} main
+${DUB} build -f --bare --compiler=${DC} main

test/issue813-pure-sub-dependency.sh

@@ -2,8 +2,5 @@
 
 . $(dirname "${BASH_SOURCE[0]}")/common.sh
 cd ${CURR_DIR}/issue813-pure-sub-dependency
-rm -rf main/.dub
-rm -rf sub/.dub
-rm -rf sub/sub/.dub
-rm -f main/dub.selections.json
-${DUB} build --bare --compiler=${DC} main
+rm -f main/~master/main/dub.selections.json
+${DUB} build -f --bare --compiler=${DC} main

test/issue923-subpackage-deps.sh

@@ -2,13 +2,10 @@
 
 . $(dirname "${BASH_SOURCE[0]}")/common.sh
 cd ${CURR_DIR}/issue923-subpackage-deps
-rm -rf main/.dub
-rm -rf a/.dub
-rm -rf b/.dub
-rm -f main/dub.selections.json
-${DUB} build --bare --compiler=${DC} main
+rm -f main/~master/main/dub.selections.json
+${DUB} build -f --bare --compiler=${DC} main
 
 
-if ! grep -c -e \"b\" main/dub.selections.json; then
+if ! grep -c -e \"b\" main/~master/main/dub.selections.json; then
 	die $LINENO 'Dependency b not resolved.'
 fi