Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer Ginan-Ops functions #47

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Transfer Ginan-Ops functions #47

merged 6 commits into from
Sep 2, 2024

Conversation

EugeneDu-GA
Copy link
Collaborator

Transfer SP3 and CLK analysis functions from ssrMonitoring to gnssanalysis
Transfer generate_sampling_rate() from auto_download_PPP to gnssanalysis

@EugeneDu-GA EugeneDu-GA self-assigned this Aug 23, 2024
ronaldmaj
ronaldmaj requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had commented on this previously, but I think this PR is looking good. The one thing I think it needs is a few unit tests on the new functions coming in

gnssanalysis/gn_diffaux.py Outdated Show resolved Hide resolved
gnssanalysis/gn_diffaux.py Show resolved Hide resolved
gnssanalysis/gn_diffaux.py Outdated Show resolved Hide resolved
gnssanalysis/gn_diffaux.py Outdated Show resolved Hide resolved
ronaldmaj
ronaldmaj approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about this in-person. Agreed to push through unit-tests in next PRs. My only other comment has been addressed

@ronaldmaj ronaldmaj merged commit 0b5a9c6 into main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmaj ronaldmaj ronaldmaj approved these changes

@seballgeyer seballgeyer Awaiting requested review from seballgeyer

@treefern treefern Awaiting requested review from treefern

Assignees

@EugeneDu-GA EugeneDu-GA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EugeneDu-GA @ronaldmaj @Eugene-ISG