Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accessing destroyed contexts in loop #55

Merged
merged 5 commits into from
Sep 1, 2014

Commits on Aug 28, 2014

  1. Avoid accessing destroyed contexts in loop

    Dispatch globally can cause certain events to close a view with bound context. This causes the destruction of the bound context. If this context has not yet been reached by the _.each loop that triggers the event on all contexts, an attempt will later be made to execute "context.vent.trigger" on a destroyed view and all further processing will abort on a "trying to access vent of undefined" error for that view.
    mmikeyy committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    aa609fc View commit details
    Browse the repository at this point in the history
  2. code properly beautified

    mmikeyy committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    b380821 View commit details
    Browse the repository at this point in the history
  3. added missing semicolon

    mmikeyy committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    edd2be3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2014

  1. Added a test

    to ensure that when contexts are all processed in sequence to trigger the event on each one, the destruction of a yet unprocessed context does not cause the program to attempt to trigger the event on it (as it no longer exists...) when the loop reaches it
    mmikeyy committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    d66e70e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1c94d1 View commit details
    Browse the repository at this point in the history