Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect TypeScript type definitions for Channel.lastMessage #1151

Closed
josh- opened this issue Aug 2, 2023 · 0 comments · Fixed by #1346
Closed

Incorrect TypeScript type definitions for Channel.lastMessage #1151

josh- opened this issue Aug 2, 2023 · 0 comments · Fixed by #1346
Assignees
Labels
bug Something isn't working status:confirmed

Comments

@josh-
Copy link

josh- commented Aug 2, 2023

Hi team,

I noticed that the type definition for Channel.lastMessage seems to be incorrect.

Here's a snippet from node_modules/stream-chat/dist/types/channel.d.ts (version 8.10.1):

    /**
     * lastMessage - return the last message, takes into account that last few messages might not be perfectly sorted
     *
     * @return {ReturnType<ChannelState<StreamChatGenerics>['formatMessage']> | undefined} Description
     */
    lastMessage(): FormatMessageResponse<StreamChatGenerics>;

(note that the return type is FormatMessageResponse<StreamChatGenerics> whereas it should be FormatMessageResponse<StreamChatGenerics> | undefined – as the JSDoc @returns statement correctly specifies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:confirmed
Projects
None yet
2 participants