-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: reduction from Sat to Coloring #56
Conversation
c-allergic
commented
Jul 31, 2024
- New: Sat => Coloring
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 89.52% 90.94% +1.41%
==========================================
Files 20 21 +1
Lines 735 795 +60
==========================================
+ Hits 658 723 +65
+ Misses 77 72 -5 ☔ View full report in Codecov by Sentry. |
src/rules/sat_coloring.jl
Outdated
coloring::Coloring{K, WT} | ||
varlabel::Dict{T, Int} | ||
end | ||
Base.:(==)(a::ReductionSatToColoring, b::ReductionSatToColoring) = a.coloring == b.coloring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this function.
src/rules/sat_coloring.jl
Outdated
|
||
|
||
""" | ||
Todo:Get the variables from the SAT problem and create 2 vertexs for themselves and their negations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please polish the docstring.
src/rules/sat_coloring.jl
Outdated
CNF2Graph(c::CNF) | ||
This function return a graph that simulates the CNF problem | ||
""" | ||
function CNF2Graph(vars::AbstractVector{T}, c::CNF) where T <: BoolVar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should be removed, maybe.