diff --git a/Local Pods/GitHubAPI/GitHubAPI.xcodeproj/project.pbxproj b/Local Pods/GitHubAPI/GitHubAPI.xcodeproj/project.pbxproj index d4b5d056a..b43023f0c 100644 --- a/Local Pods/GitHubAPI/GitHubAPI.xcodeproj/project.pbxproj +++ b/Local Pods/GitHubAPI/GitHubAPI.xcodeproj/project.pbxproj @@ -62,6 +62,7 @@ 29F8BAC0204B577800E5CA32 /* V3NotificationSubject.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29F8BABF204B577800E5CA32 /* V3NotificationSubject.swift */; }; 29F8BAC2204B57EC00E5CA32 /* V3Notification.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29F8BAC1204B57EC00E5CA32 /* V3Notification.swift */; }; 4906A18D206ADECE0031F6F5 /* invitation_notification.json in Resources */ = {isa = PBXBuildFile; fileRef = 4906A18C206ADECE0031F6F5 /* invitation_notification.json */; }; + 492557C8210BBB45009CF825 /* no_milestone_description.json in Resources */ = {isa = PBXBuildFile; fileRef = 492557C7210BBB45009CF825 /* no_milestone_description.json */; }; 496C9CE620965F2800F13F09 /* security_vulnerability.json in Resources */ = {isa = PBXBuildFile; fileRef = 496C9CE520965F2800F13F09 /* security_vulnerability.json */; }; 985AD904C6ABF3E0A1F46079 /* Pods_GitHubAPI.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = AAB687054FAA1CE0478BE468 /* Pods_GitHubAPI.framework */; }; D4D67C0931ACEE218D81A041 /* Pods_GitHubAPITests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = AD96096F323FEE96EB3F8D0D /* Pods_GitHubAPITests.framework */; }; @@ -138,6 +139,7 @@ 29F8BAC1204B57EC00E5CA32 /* V3Notification.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = V3Notification.swift; sourceTree = ""; }; 33E0718D024CC4F81EBF7364 /* Pods-GitHubAPITests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-GitHubAPITests.release.xcconfig"; path = "Pods/Target Support Files/Pods-GitHubAPITests/Pods-GitHubAPITests.release.xcconfig"; sourceTree = ""; }; 4906A18C206ADECE0031F6F5 /* invitation_notification.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = invitation_notification.json; sourceTree = ""; }; + 492557C7210BBB45009CF825 /* no_milestone_description.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = no_milestone_description.json; sourceTree = ""; }; 496C9CE520965F2800F13F09 /* security_vulnerability.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = security_vulnerability.json; sourceTree = ""; }; 8FAA1C36CB3C11579EF5BE54 /* Pods-GitHubAPI.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-GitHubAPI.release.xcconfig"; path = "Pods/Target Support Files/Pods-GitHubAPI/Pods-GitHubAPI.release.xcconfig"; sourceTree = ""; }; AAB687054FAA1CE0478BE468 /* Pods_GitHubAPI.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_GitHubAPI.framework; sourceTree = BUILT_PRODUCTS_DIR; }; @@ -253,6 +255,7 @@ 2958050A204B5A68009CFD51 /* notifications.json */, 4906A18C206ADECE0031F6F5 /* invitation_notification.json */, 496C9CE520965F2800F13F09 /* security_vulnerability.json */, + 492557C7210BBB45009CF825 /* no_milestone_description.json */, ); path = GitHubAPITests; sourceTree = ""; @@ -383,6 +386,7 @@ isa = PBXResourcesBuildPhase; buildActionMask = 2147483647; files = ( + 492557C8210BBB45009CF825 /* no_milestone_description.json in Resources */, 496C9CE620965F2800F13F09 /* security_vulnerability.json in Resources */, 2958050B204B5A68009CFD51 /* notifications.json in Resources */, 4906A18D206ADECE0031F6F5 /* invitation_notification.json in Resources */, diff --git a/Local Pods/GitHubAPI/GitHubAPI/V3Milestone.swift b/Local Pods/GitHubAPI/GitHubAPI/V3Milestone.swift index b690848f3..274cd9317 100644 --- a/Local Pods/GitHubAPI/GitHubAPI/V3Milestone.swift +++ b/Local Pods/GitHubAPI/GitHubAPI/V3Milestone.swift @@ -14,7 +14,7 @@ public struct V3Milestone: Codable { public let createdAt: Date public let closedIssues: Int public let closedAt: Date? - public let description: String + public let description: String? public let dueOn: Date? public let id: Int public let number: Int diff --git a/Local Pods/GitHubAPI/GitHubAPITests/GitHubAPITests.swift b/Local Pods/GitHubAPI/GitHubAPITests/GitHubAPITests.swift index 69ce1f27e..8678c82bd 100644 --- a/Local Pods/GitHubAPI/GitHubAPITests/GitHubAPITests.swift +++ b/Local Pods/GitHubAPI/GitHubAPITests/GitHubAPITests.swift @@ -155,5 +155,22 @@ class GitHubAPITests: XCTestCase { XCTAssertEqual(first.subject.title, "Potential security vulnerability found in the hoek dependency") } } + + func test_milestoneWithoutDescriptionsJSON() { + let data = try! Data(contentsOf: Bundle(for: type(of: self)).url(forResource: "no_milestone_description", withExtension: "json")!) + let result = processResponse(request: V3MilestoneRequest(owner: "nurpax", repo: "petmate"), input: data) + switch result { + case .failure(let error): XCTFail(error?.localizedDescription ?? "Failed without error") + case .success(let response): + XCTAssertEqual(response.data.count, 2) + + let first = response.data.first! + XCTAssertEqual(first.id, 3514116) + XCTAssertEqual(first.closedIssues, 6) + XCTAssertEqual(first.openIssues, 6) + XCTAssertNil(first.description) + XCTAssertNil(first.closedAt) + } + } } diff --git a/Local Pods/GitHubAPI/GitHubAPITests/no_milestone_description.json b/Local Pods/GitHubAPI/GitHubAPITests/no_milestone_description.json new file mode 100644 index 000000000..c4bf740bb --- /dev/null +++ b/Local Pods/GitHubAPI/GitHubAPITests/no_milestone_description.json @@ -0,0 +1,76 @@ +[ + { + "id" : 3514116, + "description" : null, + "open_issues" : 6, + "state" : "open", + "created_at" : "2018-07-22T13:29:11Z", + "labels_url" : "https://api.github.com/repos/nurpax/petmate/milestones/1/labels", + "url" : "https://api.github.com/repos/nurpax/petmate/milestones/1", + "node_id" : "MDk6TWlsZXN0b25lMzUxNDExNg==", + "closed_issues" : 6, + "title" : "0.1", + "creator" : { + "id" : 297823, + "organizations_url" : "https://api.github.com/users/nurpax/orgs", + "received_events_url" : "https://api.github.com/users/nurpax/received_events", + "following_url" : "https://api.github.com/users/nurpax/following{/other_user}", + "login" : "nurpax", + "avatar_url" : "https://avatars0.githubusercontent.com/u/297823?v=4", + "url" : "https://api.github.com/users/nurpax", + "node_id" : "MDQ6VXNlcjI5NzgyMw==", + "subscriptions_url" : "https://api.github.com/users/nurpax/subscriptions", + "repos_url" : "https://api.github.com/users/nurpax/repos", + "type" : "User", + "html_url" : "https://github.com/nurpax", + "events_url" : "https://api.github.com/users/nurpax/events{/privacy}", + "site_admin" : false, + "starred_url" : "https://api.github.com/users/nurpax/starred{/owner}{/repo}", + "gists_url" : "https://api.github.com/users/nurpax/gists{/gist_id}", + "gravatar_id" : "", + "followers_url" : "https://api.github.com/users/nurpax/followers" + }, + "html_url" : "https://github.com/nurpax/petmate/milestone/1", + "number" : 1, + "updated_at" : "2018-07-26T22:35:52Z", + "due_on" : null, + "closed_at" : null + }, + { + "id" : 3514117, + "description" : null, + "open_issues" : 4, + "state" : "open", + "created_at" : "2018-07-22T13:30:01Z", + "labels_url" : "https://api.github.com/repos/nurpax/petmate/milestones/2/labels", + "url" : "https://api.github.com/repos/nurpax/petmate/milestones/2", + "node_id" : "MDk6TWlsZXN0b25lMzUxNDExNw==", + "closed_issues" : 0, + "title" : "0.2", + "creator" : { + "id" : 297823, + "organizations_url" : "https://api.github.com/users/nurpax/orgs", + "received_events_url" : "https://api.github.com/users/nurpax/received_events", + "following_url" : "https://api.github.com/users/nurpax/following{/other_user}", + "login" : "nurpax", + "avatar_url" : "https://avatars0.githubusercontent.com/u/297823?v=4", + "url" : "https://api.github.com/users/nurpax", + "node_id" : "MDQ6VXNlcjI5NzgyMw==", + "subscriptions_url" : "https://api.github.com/users/nurpax/subscriptions", + "repos_url" : "https://api.github.com/users/nurpax/repos", + "type" : "User", + "html_url" : "https://github.com/nurpax", + "events_url" : "https://api.github.com/users/nurpax/events{/privacy}", + "site_admin" : false, + "starred_url" : "https://api.github.com/users/nurpax/starred{/owner}{/repo}", + "gists_url" : "https://api.github.com/users/nurpax/gists{/gist_id}", + "gravatar_id" : "", + "followers_url" : "https://api.github.com/users/nurpax/followers" + }, + "html_url" : "https://github.com/nurpax/petmate/milestone/2", + "number" : 2, + "updated_at" : "2018-07-26T20:51:18Z", + "due_on" : null, + "closed_at" : null + } +] diff --git a/Local Pods/GitHubSession/GitHubSession.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/Local Pods/GitHubSession/GitHubSession.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist new file mode 100644 index 000000000..18d981003 --- /dev/null +++ b/Local Pods/GitHubSession/GitHubSession.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist @@ -0,0 +1,8 @@ + + + + + IDEDidComputeMac32BitWarning + + +